New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #19858: Make MailChimp Error Handling Comprehensive #20272
Conversation
Ensure that all errors from MailChimp while signing a user up for the mailing list are caught, even those errors that arise when trying to handle missing users.
Hi @U8NWXD, can you complete the following:
|
Hi @vojtechjelinek, @DubeySandeep, @kevintab95, PTAL at this PR, it modifies files in jobs or platform folders. |
Hi @U8NWXD please assign the required reviewer(s) for this PR. Thanks! |
Per @seanlip this PR doesn't need to go through backup server testing because we can't test mailchimp on the backup server |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes @U8NWXD, LGTM for the code owner files.
Hi @U8NWXD, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks! |
Overview
Essential Checklist
Please follow the instructions for making a code change.
Proof that changes are correct
This PR only changes how errors from MailChimp (which shouldn't ever happen and no longer happen on production) are handled. Correctness is confirmed by backend tests which use mocks to artificially induce MailChimp errors, but since these changes only activate under conditions that shouldn't ever happen, we can't test this end-to-end.
PR Pointers