Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #19858: Make MailChimp Error Handling Comprehensive #20272

Merged
merged 2 commits into from May 20, 2024

Conversation

U8NWXD
Copy link
Member

@U8NWXD U8NWXD commented May 7, 2024

Overview

  1. This PR fixes [BUG]: Unable to Register on Oppia.org #19858.
  2. This PR does the following: Ensures that all errors from MailChimp while signing a user up for the mailing list are caught, even those errors that arise when trying to handle missing users. Note that this fully resolves the [BUG]: Unable to Register on Oppia.org #19858 issue because it ensures that future configuration errors don't block user signups. We have already resolved the immediate problem by making the name fields not required in the MailChimp database.
  3. (For bug-fixing PRs only) The original bug occurred because: The MailChimp server configuration was changed to require names, but the web app was not updated to provide those names. This caused user signups to the mailing list to fail, and poor error-handling led those failures to block user registration.

Essential Checklist

Please follow the instructions for making a code change.

  • I have linked the issue that this PR fixes in the "Development" section of the sidebar.
  • I have checked the "Files Changed" tab and confirmed that the changes are what I want to make.
  • I have written tests for my code.
  • The PR title starts with "Fix #bugnum: " or "Fix part of #bugnum: ...", followed by a short, clear summary of the changes.
  • I have assigned the correct reviewers to this PR (or will leave a comment with the phrase "@{{reviewer_username}} PTAL" if I can't assign them directly).

Proof that changes are correct

This PR only changes how errors from MailChimp (which shouldn't ever happen and no longer happen on production) are handled. Correctness is confirmed by backend tests which use mocks to artificially induce MailChimp errors, but since these changes only activate under conditions that shouldn't ever happen, we can't test this end-to-end.

PR Pointers

Ensure that all errors from MailChimp while signing a user up for the
mailing list are caught, even those errors that arise when trying to
handle missing users.
Copy link

oppiabot bot commented May 7, 2024

Hi @U8NWXD, can you complete the following:

  1. The proof that changes are correct has not been provided, please make sure to upload a image/video showing that the changes are correct. Or include a sentence saying "No proof of changes needed because" and the reason why proof of changes cannot be provided.
    Thanks!

@oppiabot oppiabot bot assigned U8NWXD May 7, 2024
Copy link

oppiabot bot commented May 7, 2024

Hi @vojtechjelinek, @DubeySandeep, @kevintab95, PTAL at this PR, it modifies files in jobs or platform folders.
Also @U8NWXD, please make sure to fill in the server jobs form for the new job or feature to be tested on the backup server. This PR can be merged only after the test run is successful. Please refer to this guide for details.
Thanks!

@oppiabot oppiabot bot added the PR: Affects datastore layer Labels to indicate a PR that changes the datastore layer. label May 7, 2024
Copy link

oppiabot bot commented May 7, 2024

Hi @U8NWXD please assign the required reviewer(s) for this PR. Thanks!

@U8NWXD U8NWXD marked this pull request as ready for review May 12, 2024 15:39
@U8NWXD U8NWXD requested a review from a team as a code owner May 12, 2024 15:39
@U8NWXD U8NWXD requested a review from lkbhitesh07 May 12, 2024 15:39
@U8NWXD
Copy link
Member Author

U8NWXD commented May 12, 2024

Per @seanlip this PR doesn't need to go through backup server testing because we can't test mailchimp on the backup server

Copy link
Member

@lkbhitesh07 lkbhitesh07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes @U8NWXD, LGTM for the code owner files.

@lkbhitesh07 lkbhitesh07 assigned U8NWXD and unassigned lkbhitesh07 May 17, 2024
@oppiabot oppiabot bot added the PR: LGTM label May 17, 2024
Copy link

oppiabot bot commented May 17, 2024

Hi @U8NWXD, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks!

@seanlip seanlip added this pull request to the merge queue May 20, 2024
Merged via the queue into oppia:develop with commit 24953db May 20, 2024
82 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Affects datastore layer Labels to indicate a PR that changes the datastore layer. PR: LGTM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Unable to Register on Oppia.org
6 participants