Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #14698: Add ability to generate X sample translation opportunities on local dev server for the contributor dashboard #20278

Open
wants to merge 13 commits into
base: develop
Choose a base branch
from
Open

Fix #14698: Add ability to generate X sample translation opportunities on local dev server for the contributor dashboard #20278

wants to merge 13 commits into from
+623 −7

Conversation

amaanlari
Copy link
Collaborator

@amaanlari amaanlari commented May 7, 2024 •
edited

Overview

  1. This PR fixes [CD Infra] Add ability to generate X sample translatable explorations on local dev server for the contributor dashboard #14698 .
  2. This PR does the following: Adds ability to input number of translation opportunities (explorations) from user and generate them in local dev server within admin page.

Essential Checklist

Please follow the instructions for making a code change.

  • I have linked the issue that this PR fixes in the "Development" section of the sidebar.
  • I have checked the "Files Changed" tab and confirmed that the changes are what I want to make.
  • I have written tests for my code.
  • The PR title starts with "Fix #bugnum: " or "Fix part of #bugnum: ...", followed by a short, clear summary of the changes.
  • I have assigned the correct reviewers to this PR (or will leave a comment with the phrase "@{{reviewer_username}} PTAL" if I can't assign them directly).

Proof that changes are correct

Successful.generation.of.exps.webm
non-admin.cannot.generate.webm

Proof of changes on desktop with slow/throttled network

Proof of changes on mobile phone

Proof of changes in Arabic language

PR Pointers

@oppiabot OppiaBot
Copy link

oppiabot bot commented May 7, 2024

Hi @amaanlari please assign the required reviewer(s) for this PR. Thanks!

@amaanlari amaanlari changed the title Issue #14698: Add ability to generate X sample translation opportunities on local dev server for the contributor dashboard Fix #14698: Add ability to generate X sample translation opportunities on local dev server for the contributor dashboard May 7, 2024
Akhilesh-max and others added 8 commits May 8, 2024 04:03
@Akhilesh-max
FIX a part of oppia#20175 : Acceptance test and WebDriverIo e2e tests…
dfab966 
… Proceeds to ‘it’ Block or another 'it' block/spec Despite Failure in ‘beforeAll’ setup or any other failure in the intial specs. (oppia#20192)

* updates

* updates

* updates

* updates

* updates

* updates

* updates

* updates

* updates

* updates

* updates
Unit tests for the frontend and backend
adbb146
fix failed pre push checks
7be6013
fix failed pre push checks
59c634a
fix failed pre push checks
8f08793
fix failed pre push checks
1d02d99
fix failed pre push checks
279072e
fix lint checks
6aec6f9
@amaanlari amaanlari marked this pull request as ready for review May 10, 2024 09:43
@amaanlari amaanlari requested review from a team as code owners May 10, 2024 09:43
@amaanlari
Copy link
Collaborator Author

PTAL @StephenYu2018 @seanlip

@oppiabot oppiabot bot assigned seanlip and StephenYu2018 and unassigned amaanlari May 10, 2024
@oppiabot OppiaBot
Copy link

oppiabot bot commented May 10, 2024

Unassigning @amaanlari since a re-review was requested. @amaanlari, please make sure you have addressed all review comments. Thanks!

seanlip
seanlip approved these changes May 10, 2024
View reviewed changes
Copy link
Member

@seanlip seanlip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM for two codeowner files.

@seanlip seanlip removed their assignment May 10, 2024
@oppiabot OppiaBot
Copy link

oppiabot bot commented May 10, 2024

Assigning @kevintab95 for code owner reviews. Thanks!

StephenYu2018
StephenYu2018 requested changes May 12, 2024
View reviewed changes
Copy link
Contributor

@StephenYu2018 StephenYu2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several concerns.

core/controllers/admin_test.py Outdated Show resolved Hide resolved
core/controllers/admin_test.py Outdated Show resolved Hide resolved
core/controllers/admin_test.py Show resolved Hide resolved
core/templates/pages/admin-page/activities-tab/admin-dev-mode-activities-tab.component.html Outdated Show resolved Hide resolved
core/templates/pages/admin-page/activities-tab/admin-dev-mode-activities-tab.component.spec.ts Outdated Show resolved Hide resolved
core/templates/pages/admin-page/activities-tab/admin-dev-mode-activities-tab.component.ts Outdated Show resolved Hide resolved
core/controllers/admin.py Show resolved Hide resolved
core/controllers/admin.py Outdated Show resolved Hide resolved
@oppiabot OppiaBot
Copy link

oppiabot bot commented May 12, 2024

Unassigning @StephenYu2018 since the review is done.

@oppiabot OppiaBot
Copy link

oppiabot bot commented May 12, 2024

Hi @amaanlari, it looks like some changes were requested on this pull request by @StephenYu2018. PTAL. Thanks!

@amaanlari
Copy link
Collaborator Author

PTAL @StephenYu2018

@oppiabot oppiabot bot assigned StephenYu2018 and unassigned amaanlari May 16, 2024
@oppiabot OppiaBot
Copy link

oppiabot bot commented May 16, 2024

Unassigning @amaanlari since a re-review was requested. @amaanlari, please make sure you have addressed all review comments. Thanks!

StephenYu2018
StephenYu2018 reviewed May 20, 2024
View reviewed changes
Copy link
Contributor

@StephenYu2018 StephenYu2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address my remaining review comment. Then I'll approve the changes.

@amaanlari
Copy link
Collaborator Author

PTAL @StephenYu2018 @kevintab95

StephenYu2018
StephenYu2018 approved these changes May 25, 2024
View reviewed changes
Copy link
Contributor

@StephenYu2018 StephenYu2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@oppiabot OppiaBot
Copy link

oppiabot bot commented May 25, 2024

Unassigning @StephenYu2018 since they have already approved the PR.

@amaanlari
Copy link
Collaborator Author

PTAL @kevintab95

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanlip seanlip seanlip approved these changes

@StephenYu2018 StephenYu2018 StephenYu2018 approved these changes

@kevintab95 kevintab95 Awaiting requested review from kevintab95 kevintab95 is a code owner automatically assigned from oppia/lace-frontend-reviewers

At least 1 approving review is required to merge this pull request.

Assignees

@kevintab95 kevintab95

Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@amaanlari @seanlip @StephenYu2018 @kevintab95 @Akhilesh-max