create mock asts for message bundle component | Message Component

[felixhaeberle]

• fix INLMC-88

[changeset-bot]

⚠️ No Changeset found

Latest commit: adcde5c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[felixhaeberle]

@jldec It would be nice if you could have a look at the mock message format to verify if we are going in the right direction here and add a additional mock message mockMessageBundleMinimal with the minimal number of properties.

Or better yet, do we have a real project (multiple messages in messageBundle format, query possibility) to test with the Message Component?

[jldec]

Thanks @felixhaeberle - src/stories/inlang-message-bundle.ts is showing typescript errors during build.

I just added you to also review #2795 which should help create simple mocks more easily. I'm looking for suggestions for how to easliy mock messages with selectors and variants using a createMessage() function.

Using v2 MessageBundlers with a test project is on the roadmap (MESDK-104), but we first have to be able to persist using the new v2 structure.

[jldec]

@felixhaeberle
I think we should put these mocks into sdk/v2/mocks instead, so that they can be re-used for testing etc across apps.
Please see #2795 (comment)

[jldec]

@felixhaeberle - I merged a slightly simplified and corrected plural example message bundle ast with #2795

[NilsJacobsen]

@jldec you can start making the review.

[jldec]

changes needed for function annotations and clarification needed for "formal".

[jldec]

bool should be an annotation (function) as well right?
Do you know how this function would be defined ?
I could not find it in https://github.com/unicode-org/message-format-wg/blob/main/spec/registry.md
cc: @martin-lysk @LorisSigrist for clarification of how the "formal" selector is expected to work.

[jldec]

This might also affect how the formal selectors are expressed in other parts of the AST.

[NilsJacobsen]

I did it like the plural. Can we make a separate discussion about it, so we can merge this PR.

[jldec]

LGTM thanks @NilsJacobsen