-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trigger signals and callbacks for messages not present in messages provided by loadMessages plugin #2800
Conversation
🦋 Changeset detectedLatest commit: 9e0dee6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@jldec the fix was rather small - we just need to go through the messages loaded already and substract the new messages coming from the plugin. The messages left are those that are deleted. I remember that we discussed this when we worked on the new persistence - where messages that are not present in the set of imported messages does not mean a message was deleted - it was just not in the source used by the importer. I also added a test for message creation that was missing as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - just one thing needed in the test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I just found a bug in fsWatch cleanup - fixed it and also added the test to probe for inserts and updates |
resolves opral/inlang-message-sdk#67
fixes Reactivity for messages that are deleted
adds a test for deleted and created messages