Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove language from docs configuration #3594

Merged
merged 1 commit into from May 30, 2022
Merged

Conversation

hvy
Copy link
Member

@hvy hvy commented May 30, 2022

Motivation

See below description.

Description of the changes

Tries to fix the CI failure observed in #3543, i.e. https://github.com/optuna/optuna/runs/6647370356?check_suite_focus=true.

@hvy hvy added the document Documentation related. label May 30, 2022
@c-bata c-bata self-assigned this May 30, 2022
@toshihikoyanase toshihikoyanase self-assigned this May 30, 2022
Copy link
Member

@toshihikoyanase toshihikoyanase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As for the hotfix, the change looks great. On the other hand, do we have any drawbacks?

@codecov-commenter
Copy link

Codecov Report

Merging #3594 (7b3eed6) into master (9618a93) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3594      +/-   ##
==========================================
+ Coverage   90.79%   90.81%   +0.01%     
==========================================
  Files         161      161              
  Lines       12401    12401              
==========================================
+ Hits        11260    11262       +2     
+ Misses       1141     1139       -2     
Impacted Files Coverage Δ
optuna/integration/botorch.py 98.68% <0.00%> (+0.87%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@hvy
Copy link
Member Author

hvy commented May 30, 2022

On the other hand, do we have any drawbacks?

I don't think so, please see #3594 (comment).

Copy link
Member

@c-bata c-bata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@c-bata
Copy link
Member

c-bata commented May 30, 2022

Let me merge this PR since this PR is a blocker of #3543. @toshihikoyanase Please open a follow-up issue if you have something concerns about #3594 (comment).

@c-bata c-bata added this to the v3.0.0-b1 milestone May 30, 2022
@c-bata c-bata merged commit 4bfb926 into optuna:master May 30, 2022
@hvy hvy deleted the sphinx-500 branch May 30, 2022 05:07
@toshihikoyanase
Copy link
Member

@c-bata Thank you for merging this PR. As mentioned in #3594 (comment), I don't have any concerns now.

toshihikoyanase pushed a commit to toshihikoyanase/optuna that referenced this pull request Jun 6, 2022
Remove `language` from docs configuration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
document Documentation related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants