New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove language
from docs configuration
#3594
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As for the hotfix, the change looks great. On the other hand, do we have any drawbacks?
Codecov Report
@@ Coverage Diff @@
## master #3594 +/- ##
==========================================
+ Coverage 90.79% 90.81% +0.01%
==========================================
Files 161 161
Lines 12401 12401
==========================================
+ Hits 11260 11262 +2
+ Misses 1141 1139 -2
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
I don't think so, please see #3594 (comment). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Let me merge this PR since this PR is a blocker of #3543. @toshihikoyanase Please open a follow-up issue if you have something concerns about #3594 (comment). |
@c-bata Thank you for merging this PR. As mentioned in #3594 (comment), I don't have any concerns now. |
Remove `language` from docs configuration
Motivation
See below description.
Description of the changes
Tries to fix the CI failure observed in #3543, i.e. https://github.com/optuna/optuna/runs/6647370356?check_suite_focus=true.