New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Online feature store #444

Open

yogesh266 wants to merge 105 commits into main from online-fs-hackathon-redis-elastic

Member

yogesh266 commented Nov 21, 2023

No description provided.

najiyacl and others added 2 commits

November 21, 2023 17:58


          online-fs-draft

4b6fd66


          online fs changes

da531d6

oracle-contributor-agreement bot added the OCA Verified label

github-actions bot commented Nov 21, 2023

📌 Cov diff with main:

📌 Overall coverage:

KshitizLohia changed the title ~~[WIP] Online fs hackathon redis elastic~~ Online feature store


          write operation for opensearch

dbd84ce

github-actions bot commented Nov 22, 2023

📌 Cov diff with main:

📌 Overall coverage:


          code changes for online config and offline config

72a928f

github-actions bot commented Nov 22, 2023

📌 Cov diff with main:

📌 Overall coverage:


          code changes for elastic search write

7e99720

github-actions bot commented Nov 23, 2023

📌 Cov diff with main:

📌 Overall coverage:

yogesh266 added 2 commits

November 23, 2023 12:04


          code changes for elastic search write

19102e3


          code changes for elastic search write

895608f

github-actions bot commented Nov 23, 2023

📌 Cov diff with main:

No success to gather report. 😿

📌 Overall coverage:

No success to gather report. 😿

github-actions bot commented Nov 23, 2023

📌 Cov diff with main:

📌 Overall coverage:

najiyacl and others added 2 commits

November 23, 2023 14:13


          Redis -localhost changes

3151e24


          online fs changes

8a3df25

github-actions bot commented Nov 23, 2023

📌 Cov diff with main:

📌 Overall coverage:


          online fs changes

562b9c2

github-actions bot commented Nov 23, 2023

📌 Cov diff with main:

No success to gather report. 😿

📌 Overall coverage:

No success to gather report. 😿


          online fs changes

604f0cc

github-actions bot commented Nov 23, 2023

📌 Cov diff with main:

No success to gather report. 😿

📌 Overall coverage:

No success to gather report. 😿


          online fs changes

6da6306

github-actions bot commented Nov 23, 2023

📌 Cov diff with main:

No success to gather report. 😿

📌 Overall coverage:

No success to gather report. 😿


          Redis -localhost changes

71f6908

github-actions bot commented Nov 23, 2023

📌 Cov diff with main:

📌 Overall coverage:

1 similar comment

github-actions bot commented Nov 23, 2023

📌 Cov diff with main:

📌 Overall coverage:

yogesh266 added 3 commits

November 23, 2023 18:18


          code changes for online config and refactoring

99ec88b


          code refactoring and changes

515c0e3


          code refactoring and changes

d0e869b

yogesh266 added 3 commits

February 21, 2024 13:36


          Merge branch 'feature/feature-store-marketplace-operator' of github.c…

0baedb7

…om:oracle/accelerated-data-science into online-fs-hackathon-redis-elastic

Backmerged with feature/feature-store-marketplace-operator


          resolved comments

a7369e6


          added feature-store dependecies in toml file

bf9a660

github-actions bot commented Feb 21, 2024

⚠️ This PR changed pyproject.toml file. ⚠️

PR Creator must update 📃 THIRD_PARTY_LICENSES.txt, if any 📚 library added/removed in pyproject.toml.
PR Approver must confirm 📃 THIRD_PARTY_LICENSES.txt updated, if any 📚 library added/removed in pyproject.toml.


          moved feature store client from artficatory to ads

ffffa42

github-actions bot commented Feb 21, 2024

⚠️ This PR changed pyproject.toml file. ⚠️

PR Creator must update 📃 THIRD_PARTY_LICENSES.txt, if any 📚 library added/removed in pyproject.toml.
PR Approver must confirm 📃 THIRD_PARTY_LICENSES.txt updated, if any 📚 library added/removed in pyproject.toml.

KshitizLohia previously approved these changes

View reviewed changes

Member

KshitizLohia left a comment •

edited

please attach the integration test results before you merge and create a task to create integration tests for online feature store


          add feature store import

e56a61b

KshitizLohia dismissed their stale review via

e56a61b

February 21, 2024 14:08

github-actions bot commented Feb 21, 2024

⚠️ This PR changed pyproject.toml file. ⚠️

PR Creator must update 📃 THIRD_PARTY_LICENSES.txt, if any 📚 library added/removed in pyproject.toml.
PR Approver must confirm 📃 THIRD_PARTY_LICENSES.txt updated, if any 📚 library added/removed in pyproject.toml.


          add feature store import

7012f8c

github-actions bot commented Feb 22, 2024

⚠️ This PR changed pyproject.toml file. ⚠️

PR Creator must update 📃 THIRD_PARTY_LICENSES.txt, if any 📚 library added/removed in pyproject.toml.
PR Approver must confirm 📃 THIRD_PARTY_LICENSES.txt updated, if any 📚 library added/removed in pyproject.toml.

KshitizLohia added 2 commits

February 22, 2024 08:26


          add feature store import

0f24829


          add feature store import

73426bb

github-actions bot commented Feb 22, 2024

⚠️ This PR changed pyproject.toml file. ⚠️

PR Creator must update 📃 THIRD_PARTY_LICENSES.txt, if any 📚 library added/removed in pyproject.toml.
PR Approver must confirm 📃 THIRD_PARTY_LICENSES.txt updated, if any 📚 library added/removed in pyproject.toml.


          add feature store import

adc861d

github-actions bot commented Feb 22, 2024

⚠️ This PR changed pyproject.toml file. ⚠️

PR Creator must update 📃 THIRD_PARTY_LICENSES.txt, if any 📚 library added/removed in pyproject.toml.
PR Approver must confirm 📃 THIRD_PARTY_LICENSES.txt updated, if any 📚 library added/removed in pyproject.toml.


          add feature store import

f3ba6a4

github-actions bot commented Feb 22, 2024

⚠️ This PR changed pyproject.toml file. ⚠️

PR Creator must update 📃 THIRD_PARTY_LICENSES.txt, if any 📚 library added/removed in pyproject.toml.
PR Approver must confirm 📃 THIRD_PARTY_LICENSES.txt updated, if any 📚 library added/removed in pyproject.toml.


          add doc tree

github-actions bot commented Feb 22, 2024

⚠️ This PR changed pyproject.toml file. ⚠️

PR Creator must update 📃 THIRD_PARTY_LICENSES.txt, if any 📚 library added/removed in pyproject.toml.
PR Approver must confirm 📃 THIRD_PARTY_LICENSES.txt updated, if any 📚 library added/removed in pyproject.toml.


          add doc tree

7ef67b1

github-actions bot commented Feb 22, 2024

⚠️ This PR changed pyproject.toml file. ⚠️

PR Creator must update 📃 THIRD_PARTY_LICENSES.txt, if any 📚 library added/removed in pyproject.toml.
PR Approver must confirm 📃 THIRD_PARTY_LICENSES.txt updated, if any 📚 library added/removed in pyproject.toml.


          add doc tree

2ef863a

github-actions bot commented Feb 22, 2024

⚠️ This PR changed pyproject.toml file. ⚠️

PR Creator must update 📃 THIRD_PARTY_LICENSES.txt, if any 📚 library added/removed in pyproject.toml.
PR Approver must confirm 📃 THIRD_PARTY_LICENSES.txt updated, if any 📚 library added/removed in pyproject.toml.


          Adding spark engine initialisation

03f7dba

github-actions bot commented Feb 26, 2024

⚠️ This PR changed pyproject.toml file. ⚠️

PR Creator must update 📃 THIRD_PARTY_LICENSES.txt, if any 📚 library added/removed in pyproject.toml.
PR Approver must confirm 📃 THIRD_PARTY_LICENSES.txt updated, if any 📚 library added/removed in pyproject.toml.


          Fixing issues with spark_engine

github-actions bot commented Feb 26, 2024

⚠️ This PR changed pyproject.toml file. ⚠️

PR Creator must update 📃 THIRD_PARTY_LICENSES.txt, if any 📚 library added/removed in pyproject.toml.
PR Approver must confirm 📃 THIRD_PARTY_LICENSES.txt updated, if any 📚 library added/removed in pyproject.toml.

harsh97 reviewed

View reviewed changes

ads/feature_store/execution_strategy/engine/spark_engine.py

               logger = logging.getLogger(__name__)
               class SparkEngine:
-                  def __init__(self, metastore_id: str = None, spark_session: SparkSession = None):

Member

harsh97 Feb 27, 2024

this interface is exposed to public and people could use this interface to instantiate a spark engine earlier. This will be backward incompatible change. Is it possible to revert it back? Also, in feature store class we are still passing metastoreid to this class instead of feature store id

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment