Feature/forecast auto select #825
Conversation
prasankh
requested review from
darenr,
mayoor,
mrDzurb,
VipulMascarenhas and
qiuosier
as code owners
oracle-contributor-agreement
bot
added
the
OCA Verified
| @@ -250,6 +247,23 @@ def generate_report(self): | |||
| sec9 = rc.DataTable(self.eval_metrics, index=True) | |||
| train_metrics_sections = [sec9_text, sec9] | |||
|
|
|||
| backtest_sections = [] | |||
| if self.spec.model == "auto-select": | |||
There was a problem hiding this comment.
NIT: i would recommend move it to the consts.
| str | ||
| The type of the model. | ||
| """ | ||
| from ..model_evaluator import ModelEvaluator |
There was a problem hiding this comment.
Why do we need this import here, can it be move on top?
| from .operator_config import ForecastOperatorConfig | ||
|
|
||
|
|
||
| class ModelEvaluator: |
There was a problem hiding this comment.
I noticed that there are no comments and pydocs at all :) Could you add them. I also noticed that somewhere we use typing but somewhere not, for the consistency could you add typing evarywhere?
| name=column, | ||
| )) | ||
|
|
||
| import report_creator as rc |
There was a problem hiding this comment.
why do we need this import here? Can it be moved on top?
| @@ -187,7 +187,7 @@ def run_yaml(tmpdirname, yaml_i, output_data_path, test_metrics_check=True): | |||
|
|
|||
| def populate_yaml( | |||
| tmpdirname=None, | |||
| model="auto", | |||
| model="auto-select", | |||
There was a problem hiding this comment.
What would be the difference between auto and auto-select options?
There was a problem hiding this comment.
To avoid the confusion, we replaced 'auto' with auto-select. auto was ambiguous a bit as we have automlx models. auto-select indicates that the system automatically chooses the best framework or model more clearly.
ODSC-54590
auto-selectoption.