-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aqua/refactor - optimization #828
Conversation
Many tests are failing https://github.com/oracle/accelerated-data-science/actions/runs/9036162812/job/24832484555 |
The failing test for opctl probably from merging conflict. I will update it one more time to check. The rest tests are failing in feature/aquav1.0.2 before this PR : https://github.com/oracle/accelerated-data-science/actions/runs/9025038228 |
ads/aqua/utils.py
Outdated
DEFAULT_FT_REPLICA = 1 | ||
DEFAULT_FT_BATCH_SIZE = 1 | ||
DEFAULT_FT_VALIDATION_SET_SIZE = 0.1 | ||
HF_MODELS = "/home/datascience/conda/pytorch21_p39_gpu_v1/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this a temp constant? Do we still need to keep this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This constant is not being used now. I will remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let us not touch non-aqua files in this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it! It comes from resolving merge conflict. I will revert the change on the two files.
bde1539
to
f19e023
Compare
PR closed. Will move the necessary change in to separate PR. |
Description
This PR contains the first step of the refactoring work. Breaking down the change into step by step for convenient review. There will be another PR later for more refactor. To avoid breaking change, I haven't remove the original version for all moving. We will remove it in the last step.
Major Change
constants.py
.enums.py
.evaluation.py
to leverage new module.evaluation.py
Next step
Test