Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aqua/refactor - optimization #828

Closed
wants to merge 10 commits into from
Closed

Conversation

mingkang111
Copy link
Member

@mingkang111 mingkang111 commented May 10, 2024

Description

This PR contains the first step of the refactoring work. Breaking down the change into step by step for convenient review. There will be another PR later for more refactor. To avoid breaking change, I haven't remove the original version for all moving. We will remove it in the last step.

Major Change

  • Provided centralized management for aqua job/model resources.
  • Moved constants to constants.py.
  • Moved all enums to enums.py.
  • Refactor evaluation.py to leverage new module.
  • Restructure evaluation.py
aqua
|
--evaluation
       |
       --- __init__.py
       |
       --- evaluation.py
       |
       --- errors.py
       |
       --- entities.py
       |
       --- constants.py

Next step

  • Use wrapper in FT modules.

Test

Screenshot 2024-05-09 at 20 09 50 Screenshot 2024-05-09 at 20 10 54

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label May 10, 2024
@qiuosier
Copy link
Member

Many tests are failing https://github.com/oracle/accelerated-data-science/actions/runs/9036162812/job/24832484555
Something wrong with mocking the auth?

@mingkang111
Copy link
Member Author

Many tests are failing https://github.com/oracle/accelerated-data-science/actions/runs/9036162812/job/24832484555 Something wrong with mocking the auth?

The failing test for opctl probably from merging conflict. I will update it one more time to check.

The rest tests are failing in feature/aquav1.0.2 before this PR : https://github.com/oracle/accelerated-data-science/actions/runs/9025038228

DEFAULT_FT_REPLICA = 1
DEFAULT_FT_BATCH_SIZE = 1
DEFAULT_FT_VALIDATION_SET_SIZE = 0.1
HF_MODELS = "/home/datascience/conda/pytorch21_p39_gpu_v1/"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this a temp constant? Do we still need to keep this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This constant is not being used now. I will remove it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let us not touch non-aqua files in this PR

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it! It comes from resolving merge conflict. I will revert the change on the two files.

@mingkang111 mingkang111 changed the title Aqua/refactor Aqua/refactor - optimization May 13, 2024
@mingkang111
Copy link
Member Author

PR closed. Will move the necessary change in to separate PR.

@mingkang111 mingkang111 deleted the aqua/refactor_1 branch May 17, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants