Aqua/refactor - reorganize code #837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mingkang111
requested review from
darenr,
mayoor,
mrDzurb,
VipulMascarenhas and
qiuosier
as code owners
oracle-contributor-agreement
bot
added
the
OCA Verified
mrDzurb
approved these changes
May 13, 2024
|
Refactored |
|
Tested the APIs with the changes in this branch, made a couple fixes. Looks good to merge. |
mayoor
approved these changes
May 14, 2024
mingkang111
force-pushed
the
aqua/refactor_2
branch
from
5275f69
to
cbc4bf1
Compare
|
Testing Results: |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reorganizing the existing code without altering its functionality or logic.
Changed
base.pytoapp.pyTesting
All AQUA tests passing:
https://github.com/oracle/accelerated-data-science/actions/runs/9084981550
https://github.com/oracle/accelerated-data-science/actions/runs/9085418581
https://github.com/oracle/accelerated-data-science/actions/runs/9085412264
The failing tests is related to the recent langchain-core update, pin version in :#843