-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding OHS 12.2.1.4 dockerfiles and removing 12.2.1.3 which is no lon… #2796
base: main
Are you sure you want to change the base?
Conversation
@@ -75,4 +75,4 @@ To download and run Oracle JDK regardless of inside or outside a Docker containe | |||
All scripts and files hosted in this project and GitHub [docker/OracleHTTPServer](./) repository required to build the Docker images are, unless otherwise noted, released under the Universal Permissive License v1.0. | |||
|
|||
## Copyright | |||
Copyright (c) 2019 Oracle and/or its affiliates. All rights reserved. | |||
Copyright (c) 2019, 2024 Oracle and/or its affiliates. All rights reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs comma after 2024 :)
@@ -1,4 +1,4 @@ | |||
Copyright (c) 2001, 2019, Oracle Corporation. All rights reserved. | |||
Copyright (c) 2001, 2024, Oracle Corporation. All rights reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest copyright content looks like this:
Copyright (c) 2020, 2024, Oracle and/or its affiliates.
Licensed under the Universal Permissive License v 1.0 as shown at https://oss.oracle.com/licenses/upl.
|
||
|
||
## Support | ||
Oracle HTTP Server on Docker is supported by Oracle. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of "on Docker", we should probably be saying "in containers"
|
||
|
||
## License | ||
To download and run Oracle HTTP Server 12c Distribution regardless of inside or outside a Docker container, and regardless of the distribution, you must download the binaries from Oracle website and accept the license indicated at that page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment for these other usages of "Docker". Here we can just drop the word "Docker".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving... a few comments on copyrights (of course!) and a suggestion to look at each usage of the word "Docker" to see if it can be made generic for any container environment.
Adding OHS 12.2.1.4 dockerfiles and removing 12.2.1.3 which is no longer supported.
Making changes container-scripts so that things like the Domain_HOME come from the environment variable.
Create 12.2.1.4 sample for patching