Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding OHS 12.2.1.4 dockerfiles and removing 12.2.1.3 which is no lon… #2796

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mriccell
Copy link
Member

@mriccell mriccell commented May 7, 2024

Adding OHS 12.2.1.4 dockerfiles and removing 12.2.1.3 which is no longer supported.
Making changes container-scripts so that things like the Domain_HOME come from the environment variable.
Create 12.2.1.4 sample for patching

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label May 7, 2024
@mriccell mriccell requested a review from rjeberhard May 7, 2024 19:26
@@ -75,4 +75,4 @@ To download and run Oracle JDK regardless of inside or outside a Docker containe
All scripts and files hosted in this project and GitHub [docker/OracleHTTPServer](./) repository required to build the Docker images are, unless otherwise noted, released under the Universal Permissive License v1.0.

## Copyright
Copyright (c) 2019 Oracle and/or its affiliates. All rights reserved.
Copyright (c) 2019, 2024 Oracle and/or its affiliates. All rights reserved.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs comma after 2024 :)

@@ -1,4 +1,4 @@
Copyright (c) 2001, 2019, Oracle Corporation. All rights reserved.
Copyright (c) 2001, 2024, Oracle Corporation. All rights reserved.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest copyright content looks like this:

Copyright (c) 2020, 2024, Oracle and/or its affiliates.
Licensed under the Universal Permissive License v 1.0 as shown at https://oss.oracle.com/licenses/upl.



## Support
Oracle HTTP Server on Docker is supported by Oracle.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of "on Docker", we should probably be saying "in containers"



## License
To download and run Oracle HTTP Server 12c Distribution regardless of inside or outside a Docker container, and regardless of the distribution, you must download the binaries from Oracle website and accept the license indicated at that page.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment for these other usages of "Docker". Here we can just drop the word "Docker".

Copy link
Member

@rjeberhard rjeberhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving... a few comments on copyrights (of course!) and a suggestion to look at each usage of the word "Docker" to see if it can be made generic for any container environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants