Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Less indented (but full) stacktrace in IGV #8405

Closed
wants to merge 1 commit into from
Closed

Less indented (but full) stacktrace in IGV #8405

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
15 changes: 11 additions & 4 deletions ...zer/SourceRepository/src/org/graalvm/visualizer/source/impl/ui/StackViewTopComponent.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -642,7 +642,7 @@ protected Sheet createSheet() {
return s;
}
};
node.setDisplayName(provider.getProperties().getString(PROPNAME_NAME, "")); // NOI18N
node.setDisplayName(provider.getProperties().getString(PROPNAME_NAME, "")); // NOI18N
setActivatedNodes(new Node[]{node});
}
}
Expand Down Expand Up @@ -702,10 +702,17 @@ private void updateComboContents(NodeStack locs) {
}
}
}
NodeStack.Frame head = locs.bottom();
ChainNode node = new ChainNode(head, head.getLookup().lookup(Node.class),
head.getNested() == null ? Children.LEAF : new ChainChildren(head));
final int indentLevel = 24;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This constant can change, but no more than to 50 as limited here.

Children.Array arr = new Children.Array();
for (int i = locs.size() - 1; i > indentLevel; i--) {
NodeStack.Frame frame = locs.get(i);
ChainNode node = new ChainNode(frame, frame.getLookup().lookup(Node.class),Children.LEAF);
arr.add(new Node[]{node});
}

NodeStack.Frame head = locs.size() > indentLevel ? locs.get(indentLevel) : locs.bottom();
Children children = head.getNested() == null ? Children.LEAF : new ChainChildren(head);
ChainNode node = new ChainNode(head, head.getLookup().lookup(Node.class), children);
arr.add(new Node[]{node});
manager.setRootContext(new AbstractNode(arr));
Node toSelect = findNode(locs.top());
Expand Down