Omit unnecessary AMD64 TEST instruction #8539
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is inspired by similar change in JDK. When a TEST instruction immediately follows one of AND/OR/XOR, it may be left out because the necessary flags (SF, ZF) are already set.
This patch might probably be structured better, and extended to support more cases. But first I'd just like to check if the approach taken is sane and overall makes sense, so I'd appreciate comments and criticisms.