Use callTarget.id instead of hashCode in OptimizedTruffleRuntime and TraceSplittingListener #8654
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This format is consistent with the format for splits present in the
"[engine] opt" lines when tracing compilation.
Using
--engine.TraceCompilation --engine.TraceSplitting --engine.TraceTransferToInterpreter
the output changes from
to
The
id
is apublic final
graal/truffle/src/com.oracle.truffle.runtime/src/com/oracle/truffle/runtime/OptimizedCallTarget.java
Line 357 in 2a77e42
Currently this keeps the format of "splitCount-splitId-callCount" in the TraceSplittingListener the same, but if that isn't valuable it might be nice to reformat it so that each line has
split-1722
which might make finding those easier.What do you think about this? Do we need anything else here?