Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GR-49770] Use Glob Patterns In Resource Config File #8715

Open
wants to merge 79 commits into
base: master
Choose a base branch
from
Open

[GR-49770] Use Glob Patterns In Resource Config File #8715

wants to merge 79 commits into from

Conversation

graalvmbot
Copy link
Collaborator

This PR:

  • Changes native-image agent to print resource patterns in new format using glob instead of regex
  • Tries to convert all regex to glob for all trivial entries in resource-config file
  • Adds customized Trie structure that stores globs without sufficient patterns (if one pattern covers the other one, only the more general pattern will be added). The structure is compressed and immutable
  • Uses Trie structure to search for patterns that matches given resource

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Apr 5, 2024
@graalvmbot graalvmbot force-pushed the dnestoro/GR-49770/MakeResourceConfigUseNewFormat branch 2 times, most recently from fe65af9 to ed70b3e Compare April 15, 2024 08:57
@dnestoro
Make agent print modules and patterns in new format
3eace0b
@dnestoro
Add CompressedGlobTrie structure and tests
5acfed3
@dnestoro
Parse new format in ResourceConfigurationParser
0df5586
@dnestoro
Fix json printer
8c10eaf
@dnestoro
Initial merge config files solution
15d088b
@dnestoro
Change configuration parser to read globs and load them into trie str…
58b35c0 
…ucture
@dnestoro
Change sorting rules and make function returns all patterns that matc…
4441513 
…hes text instead of one
@dnestoro
Update some comments
94371f1
@dnestoro
Remove redudant checks
ecf1687
@dnestoro
Add pattern validation mechanism
5dc1225
@dnestoro
Update json schema according to changes introduced in this pull request
4816753
@dnestoro
Refactor after resolving merge conflicts
3205ae3
@dnestoro
Relax pattern validation to allow lambdas and inner classes
8c504e0
@dnestoro
Don't try to convert regexes that contains more than one \Q
a1bb22c
@dnestoro
Add licenses for newly added files
87ba4cf
@dnestoro
Basic refactoring
3fdcdeb
@dnestoro
Revert addedPatterns list to use compiled patterns instead of strings
57df56f
@dnestoro
Remove leading slash from glob patterns
5ac29c9
@dnestoro
Basic refactor
56bd95e
@dnestoro
Fix style gates
cced80c
@dnestoro
Change parameter name to avoid style gate failures
9236f3d
@dnestoro
Add util function to concatenate resource name to module
cf79673
@dnestoro
Reordering actions in ResourcesFeature beforeAnalysis
40fa8ab
@dnestoro
Check globs in runtime when searching for missing metadata
1b62e47
@dnestoro
Fix style
833e790
@dnestoro
Add and update class headers
e6e51bb
@dnestoro
Revert usage of ignoredResources
8d433e4
@dnestoro
Use char override of indexOf instead of the string variant of this fu…
cb29ad5 
…nction
@dnestoro
Change comments style
097ad84
@dnestoro
Make classifyPatterns returning invalid patterns
00fa425
@dnestoro
Small style changes
deb0a5b
@dnestoro
Remove public modifiers from constructors in TrieNode classes
f2078b4
@dnestoro
Trim List and Map sizes after the building of Trie
6cd7a3b
@dnestoro
Refactor classifyPatterns to be more readable
83699a6
@dnestoro
Add few more comments
a3a6352
@dnestoro
Revert unnecessary change
b729e1a
@dnestoro
Update headers of changed files
eea8f2e
@dnestoro
Add changelog entry
ba1ab5e
@dnestoro
Make isSimpleQuotedPattern function more readable
262a177
@dnestoro
Use Collections.newSetFromMap in all places
fcc911b
@dnestoro
Remove unnecessary string concatenation
4755f28
@dnestoro
Fix comment missing punctuation
47f4d5e
@dnestoro
Add platform dependant line separator
c8261b4
@dnestoro
Remove redudant variable
1131b9d
@dnestoro
Replace usages of plain string wildcards with constants
9f35651
@dnestoro
Extract counting of stars in a pattern into function
2b8ca66
@dnestoro
Precompile validation regexes
7143e1d
@dnestoro
Add comment that explains purpose of SquashedParts record
079b81f
@dnestoro
Make SAME_LEVEL_IDENTIFIER visible to tests
15b1249
@dnestoro
Remove directory support
772f9c8
@dnestoro
Use MODULE_KEY instead of hardcoded string
ab9df92
@dnestoro
Calculate number of chars in string faster
bf0b4b5
@dnestoro
Use level instead of layer everywhere
3e16e76
@dnestoro
Use star constant everywhere
efc7e1f
@dnestoro
Introduce GLOB_KEY constant
0167958
@graalvmbot graalvmbot force-pushed the dnestoro/GR-49770/MakeResourceConfigUseNewFormat branch from ed70b3e to 0167958 Compare May 10, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@graalvmbot @dnestoro