Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change CSV format of call tree report #8774

Merged
merged 4 commits into from May 1, 2024
Merged

Conversation

mv02
Copy link
Contributor

@mv02 mv02 commented Apr 15, 2024

Related issue: #8496

This pull request reworks and simplifies the CSV output format of call graph report, generated by running Native Image with the -H:+PrintAnalysisCallTree and -H:PrintAnalysisCallTreeType=CSV options.

The new format consists of 3 files:

call_tree_methods.csv

Id | Name | Type | Parameters | Return | Display | Flags | IsEntryPoint

call_tree_invokes.csv

Id | MethodId | BytecodeIndexes | TargetId | IsDirect

call_tree_targets.csv

InvokeId | TargetId

The first two files represent a list of methods and invokes, respectively, while the targets file creates a many-to-many mapping between invokes and target methods. This replaces the original system of direct and virtual nodes and edges. Direct and virtual calls are simply distinguished by IsDirect and they are connected to all relevant method implementations. Entrypoints are not listed in a separate file anymore, instead they are marked by a new column in the methods file.

Most importantly, the new format eliminates the imprecision described in #8496.

Copy link

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. label Apr 15, 2024
Copy link

Thank you for signing the OCA.

@oracle-contributor-agreement oracle-contributor-agreement bot added OCA Verified All contributors have signed the Oracle Contributor Agreement. and removed OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. labels Apr 16, 2024
@d-kozak d-kozak self-assigned this Apr 18, 2024
@d-kozak d-kozak requested a review from cstancu April 18, 2024 07:58
@d-kozak
Copy link
Contributor

d-kozak commented Apr 18, 2024

@galderz Are you okay with merging this PR or would you like some changes?

@d-kozak d-kozak self-requested a review April 18, 2024 08:12
@galderz
Copy link
Contributor

galderz commented Apr 19, 2024

@d-kozak Looks good

@galderz
Copy link
Contributor

galderz commented Apr 19, 2024

And thanks @mv02 for tackling this!

@graalvmbot graalvmbot merged commit ebbb478 into oracle:master May 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants