Print exception details/stacktrace when failed to add a library #8888
Conversation
oracle-contributor-agreement
bot
added
the
OCA Verified
|
Hey @Eng-Fouad, Thank you for your contribution! @wirthi Could you please assign this to someone that can review this PR. Thanks a lot! |
| @@ -146,6 +146,7 @@ private boolean loadLibrary0(File file, boolean builtin) { | |||
| String canonical = builtin ? file.getName() : file.getCanonicalPath(); | |||
| return addLibrary(canonical, builtin); | |||
| } catch (IOException e) { | |||
| e.printStackTrace(); | |||
There was a problem hiding this comment.
We don't know where the library is supposed to be and this method is used for probing, so adding this might print several unhelpful stack traces even when the library can ultimately be loaded. I believe the behavior is the same in OpenJDK, see jdk.internal.loader.NativeLibraries#loadLibrary(java.lang.Class<?>, java.io.File).
There was a problem hiding this comment.
@peter-hofer At least print it with debug level if possible instead of hiding the exception details entirely.
I faced a problem in the past when trying to load awt in native image. I got the message UnsatisfiedLinkError: Can't load library: awt which didn't help me to identify the real cause. After several days, I solved the problem by including other .so shared libs (beside libawt.so I had to include libawt_headless.so, libawt_xawt.so, libjava.so, libjvm.so) and registering few methods in jni-config.json (extracted by the help of tracing agent).
Resolves #8887