Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GR-53982] Make icu4j dependency on java.desktop optional. #8908

Merged
merged 2 commits into from May 13, 2024

Conversation

graalvmbot
Copy link
Collaborator

@graalvmbot graalvmbot commented May 10, 2024

Fixes #8889.

  • Make icu4j dependency on java.desktop optional, only used by Bidi.setPara(AttributedCharacterIterator).
  • Also make icu4j dependency on java.xml optional, only used by BasicDurationFormat, the implementation of the deprecated DurationFormat.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label May 10, 2024
@fniephaus fniephaus requested review from woess and removed request for woess May 10, 2024 17:31
@fniephaus
Copy link
Member

FYI @JaroslavTulach

@JaroslavTulach
Copy link
Contributor

I can confirm, I am able to start Enso with Graal.js on a JDK reduced by jlink:

$ /graalvm/bin/jlink --output jdk --add-modules java.net.http,jdk.unsupported,java.sql,jdk.management,jdk.jfr

with the icu4j provided by this PR.

@woess
Copy link
Member

woess commented May 13, 2024

@JaroslavTulach thanks for confirming! I like simple fixes like this one. :)

@graalvmbot graalvmbot closed this May 13, 2024
@graalvmbot graalvmbot deleted the aw/GR-53982-icu4j-no-desktop branch May 13, 2024 22:30
@graalvmbot graalvmbot merged commit 54a972c into master May 13, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Too heavyweight org.graalvm.shadowed.icu4j
4 participants