Skip to content

Commit

Permalink
build: build ICU with ICU_NO_USER_DATA_OVERRIDE
Browse files Browse the repository at this point in the history
Backport-PR-URL: https://github.com/nodejs-private/node-private/pull/378
CVE-ID: CVE-2023-23920
PR-URL: https://github.com/nodejs-private/node-private/pull/374
Refs: https://hackerone.com/bugs?subject=nodejs&report_id=1625036
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
  • Loading branch information
RafaelGSS authored and oraluben committed Mar 17, 2023
1 parent 10d05f8 commit c98f408
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions configure.py
Expand Up @@ -1653,6 +1653,9 @@ def icu_download(path):
# always set icu_small, node.gyp depends on it being defined.
o['variables']['icu_small'] = b(False)

# prevent data override
o['defines'] += ['ICU_NO_USER_DATA_OVERRIDE']

with_intl = options.with_intl
with_icu_source = options.with_icu_source
have_icu_path = bool(options.with_icu_path)
Expand Down

0 comments on commit c98f408

Please sign in to comment.