Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#911): Swithing puppeteer to puppeteer core #965

Merged
merged 1 commit into from Feb 24, 2022

Conversation

captaincole
Copy link
Contributor

@captaincole captaincole commented Feb 23, 2022

Fixes this issue: #911

Specifically we:

  • Puppeteer to Puppeteer Core
  • Because of an issue with M1 Macs Chromium problems, we include chromium as a dev dependency See this issue

@tabcat
Copy link
Member

tabcat commented Feb 23, 2022

Thanks for making this, my original intention moving it to puppeteer-core was to delay chromium binary installation until the tests were being ran the first time. Since it looks like pupperteer is broken for M1 macs and the chromium package can also delay installation this looks great. We can add the delay install part later.

Thanks again for making this pr @captaincole !
I'll be sure to check it out closer and merge it today.

@tabcat tabcat merged commit 0e70116 into orbitdb:main Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants