Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finally!! a working demo using webpack as a remote and vite as a host #480

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

mostafa-raafat
Copy link

feat: add webpack-vite demo

Description

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Code of Conduct and follow the Commit Convention guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@mostafa-raafat mostafa-raafat changed the title Finally a working demo using webpack as a remote and vite as a host Finally!! a working demo using webpack as a remote and vite as a host Aug 14, 2023
@ruleeeer ruleeeer self-requested a review August 19, 2023 04:20
@mostafa-raafat
Copy link
Author

Hi @ruleeeer Please check again.

@AsuraKev
Copy link

Does this demo have issues with sharing dependencies? @mostafa-raafat

@ruleeeer
Copy link
Collaborator

The test cases all seem to have failed, because the installation dependency failed.
image

Is the pnpm.lock file not updated or is not using pnpm as the package manager?

@AsuraKev
Copy link

AsuraKev commented Sep 8, 2023

@mostafa-raafat Do you think this ll work vice versa? I am thinking of using Next js (Webpack based) as host and vite for remote apps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants