Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make scroll directive standalone #427

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kwiateusz
Copy link

As this app uses Angular v16 it's great time to make this standalone. Backward compatibility has been preserved but I've marked module as deprecated.

By the way, I've removed the unused service to keep code clean and put access modifiers in directive methods. I think they shouldn't be used as public but if I'm wrong I can revert that.

@orizens
Copy link
Owner

orizens commented Sep 18, 2023

hi @kwiateusz
ngxis was once exported as a standalone component.
whats the motivation for not using it as a module?

@kwiateusz
Copy link
Author

Hi,

Standalone components are becoming the standard, and on top of that, importing the directive itself is more transparent.

When importing a module, until I look in the code, I don't know if there is only the directive I need or some others I may not use and they only pump bundle size because of not allowing for the shaking.

I know it's not a case here but making this standalone doesn't provide additional work in further maintenance and follows angular way of providing things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants