fix bug

orklah · Dec 4, 2020 · f08bfcc · f08bfcc
1 parent 2228162
commit f08bfcc
Showing 1 changed file with 14 additions and 5 deletions.
diff --git a/hooks/InsaneComparisonAnalyzer.php b/hooks/InsaneComparisonAnalyzer.php
@@ -104,12 +104,21 @@ public static function afterExpressionAnalysis(
 
         $eligible_string = null;
         foreach ($string_operand->getAtomicTypes() as $possibly_string) {
-            if ($possibly_string instanceof TLiteralString && preg_match('#[a-zA-Z]#', $possibly_string->value[0] ?? '')) {
-                $eligible_string = $possibly_string;
-                break;
+            if ($possibly_string instanceof TLiteralString) {
+                if(preg_match('#[a-zA-Z]#', $possibly_string->value[0] ?? '')) {
+                    $eligible_string = $possibly_string;
+                    break;
+                }
+                continue;
             } elseif ($possibly_string instanceof TSingleLetter && preg_match('#[a-zA-Z]#', $possibly_string->value[0] ?? '')) {
-                $eligible_string = $possibly_string;
-                break;
+                if(preg_match('#[a-zA-Z]#', $possibly_string->value[0] ?? '')) {
+                    $eligible_string = $possibly_string;
+                    break;
+                }
+                continue;
+            } elseif ($possibly_string instanceof Type\Atomic\TNumericString) {
+                // not interested
+                continue;
             } elseif ($possibly_string instanceof Type\Atomic\TString) {
                 $eligible_string = $possibly_string;
                 break;