Merge pull request #4 from kkmuffme/allow-from-docblock-configurable

configurable: allow fixes for types from docblock
orklah · Apr 28, 2024 · b12333a · b12333a
2 parents 81c2487 + 352b74c
commit b12333a
Showing 1 changed file with 19 additions and 2 deletions.
diff --git a/src/Hooks/NotEmptyHooks.php b/src/Hooks/NotEmptyHooks.php
@@ -5,6 +5,7 @@
 use PhpParser\Node\Expr\BooleanNot;
 use PhpParser\Node\Expr\Empty_;
 use PhpParser\Node\Expr\Variable;
+use Psalm\Config;
 use Psalm\FileManipulation;
 use Psalm\Plugin\EventHandler\AfterExpressionAnalysisInterface;
 use Psalm\Plugin\EventHandler\Event\AfterExpressionAnalysisEvent;
@@ -51,8 +52,24 @@ public static function afterExpressionAnalysis(AfterExpressionAnalysisEvent $eve
         }
 
         if ($type->from_docblock) {
-            //TODO: maybe add an issue in non alter mode
-            return null;
+            $allow_docblock = false;
+            $config = Config::getInstance();
+            foreach ($config->getPluginClasses() as $plugin) {
+                if ($plugin['class'] !== 'Orklah\NotEmpty\Plugin') {
+                    continue;
+                }
+
+                if (isset($plugin['config']->fromDocblock['value']) && (string) $plugin['config']->fromDocblock['value'] === 'true') {
+                    $allow_docblock = true;
+                }
+
+                break;
+            }
+
+            if ($allow_docblock === false) {
+                //TODO: maybe add an issue in non alter mode
+                return null;
+            }
         }
 
         if (!is_string($expr->expr->name)) {