Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jest-config-react-native)!: bump jest-expo [no issue] #1068

Merged
merged 5 commits into from May 27, 2024

Conversation

theohdv
Copy link
Contributor

@theohdv theohdv commented Mar 14, 2024

Context

Need tu upgrade jest-expo deps

BREAKING: Expo 50

@theohdv theohdv requested a review from a team as a code owner March 14, 2024 10:26
Copy link

reviewflow bot commented Mar 14, 2024

Progress

☑️ Step 1: ✏️ Write code
☑️ Step 2: 💚 Checks
☑️ Step 3: 👌 Code Review
☑️ Step 4: 🚦 Merge Pull Request

Options:

  • 🔜 automerge: Automatically merge when this PR is ready and has no failed statuses. When the repository requires branches to be up to date before merging, it merges default branch, with a queue per repo to prevent multiple merges when several PRs are ready. A fail job prevents the merge.
  • 🚦 skip-ci: Add [skip ci] on merge commit when merge is done with autoMerge.

Actions:

  • 🐛 Force updating reviewflow checks for this PR. Use this to try to fix reviewflow checks that are still missing/pending, which might happen if webhook failed or something bad happened when reviewflow tried to send the status check to github.
  • 🔄 update branch: Merge base branch in this PR's branch. Only works if merging is possible without conflicts.

Copy link

reviewflow bot commented Mar 14, 2024

@theohdv : Force-pushing after the review started is a bad practice. See https://ornikar.atlassian.net/wiki/spaces/TECH/pages/2972090451/Commits+and+Pull+Requests#Code-Review for more information.

Copy link

reviewflow bot commented Mar 14, 2024

@theohdv : Force-pushing after the review started is a bad practice. See https://ornikar.atlassian.net/wiki/spaces/TECH/pages/2972090451/Commits+and+Pull+Requests#Code-Review for more information.

@theohdv theohdv marked this pull request as draft March 14, 2024 10:29
@theohdv theohdv marked this pull request as ready for review March 19, 2024 10:42
Copy link

@ttRmz ttRmz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@PSniezak
Copy link
Contributor

Yo, je commente car j'ai mergé main et rajouté un catch d'une autre erreur react native (avec les autres déjà ignorées).

@reviewflow reviewflow bot added the 🔜 automerge Synced by reviewflow for merge/automerge label May 27, 2024
@reviewflow reviewflow bot merged commit 09341bc into main May 27, 2024
10 checks passed
@reviewflow reviewflow bot deleted the feat/expo-50 branch May 27, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔜 automerge Synced by reviewflow for merge/automerge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants