Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: shallow snapshots with decorators [no issue] #170

Merged
merged 1 commit into from May 6, 2019

Conversation

christophehurpeau
Copy link
Contributor

@christophehurpeau christophehurpeau commented May 6, 2019

Context

enzymejs/enzyme#1966 a été mergée et dispo depuis les derniers plateform days

Les snapshots ont maintenant une utilitée !

Exemple:

● sections/Instructor/CommentsDrawer/Comment › No Author

- Snapshot
+ Received

- <div>
-   <ContextProvider>
-     <MockResults>
-       <JestStoryWrapper>
-         <Comment
-           comment={
-             CommentResource {
-               "author": null,
-               "comment": "Contenu du commentaire.",
-               "created_at": "2014-12-17 17:11:29",
-               "id": 4,
-               "updated_at": "2014-12-17 17:11:29",
-               Symbol(Defined Members): Array [
-                 "id",
-                 "comment",
-                 "created_at",
-                 "updated_at",
-                 "author",
-               ],
-             }
-           }
-         />
-       </JestStoryWrapper>
-     </MockResults>
-   </ContextProvider>
- </div>
+ <Comment
+   author={
+     <Text
+       strong={true}
+     >
+       MS
+     </Text>
+   }
+   avatar={<UserAvatar />}
+   className="Comment"
+   content="Contenu du commentaire."
+   datetime={
+     <FormattedDate
+       day="2-digit"
+       month="numeric"
+       value="2014-12-17 17:11:29"
+       year="numeric"
+     />
+   }
+ />

Options:

  • This PR is a feature branch
  • Automatic branch delete after this PR is merged

@christophehurpeau christophehurpeau changed the title fix: shallow snapshots with decorators fix: shallow snapshots with decorators [no issue] May 6, 2019
@christophehurpeau christophehurpeau added the 🔜 automerge Synced by reviewflow for merge/automerge label May 6, 2019
@reviewflow reviewflow bot merged commit e98bf4e into master May 6, 2019
@reviewflow reviewflow bot deleted the fix/shallow-snapshots-with-decorators branch May 6, 2019 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔜 automerge Synced by reviewflow for merge/automerge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants