cmake: Allow PYTHON_SITE_PACKAGES_INSTALL_DIR set extern #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The variable PYTHON_SITE_PACKAGES_INSTALL_DIR is kind of hardcoded in the CMakeLists.txt to .../dist-packages. This is not true for all linux distros. dist-packages comes from debian and debian like distros. Python core uses site-packages. We use an unintrusive way and allow the variable to be passed from cmake, so you at least have the option to set a different install location (i.e. site-packages) from extern. Signed-off-by: Matthias Schoepfer <matthias.schoepfer@googlemail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The variable PYTHON_SITE_PACKAGES_INSTALL_DIR is kind of hardcoded in the CMakeLists.txt to .../dist-packages. This is not true for all linux distros. dist-packages comes from debian and debian like distros. Python core uses site-packages.
We use an unintrusive way and allow the variable to be passed from cmake, so you at least have the option to set a different install location (i.e. site-packages) from extern.