Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mount secrets to initContainer as well #684

Merged
merged 3 commits into from
May 20, 2024
Merged

Conversation

meysam81
Copy link
Contributor

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@CLAassistant
Copy link

CLAassistant commented May 17, 2024

CLA assistant check
All committers have signed the CLA.

@Demonsthere Demonsthere changed the title fix(kratos): mount secrets to initContainer as well fix: mount secrets to initContainer as well May 17, 2024
@Demonsthere
Copy link
Collaborator

Hi there!
I have no real issue with the changes, just one question: do you think that we should use the same envFrom clause in the case of initJob? The initcontainer is an option,. but not the default, and it would make sense for me to load the same envs in the job that does the migration.

@meysam81
Copy link
Contributor Author

@Demonsthere
You're right, it should be present for initJob as well. 👍

@Demonsthere Demonsthere merged commit f68d6d1 into ory:master May 20, 2024
11 checks passed
@meysam81 meysam81 deleted the patch-1 branch May 20, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants