Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade typescript client axios to version 1.6.2 #314

Closed
wants to merge 1 commit into from

Conversation

amirzahavi
Copy link

Related Issue or Design Document

#305

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@CLAassistant
Copy link

CLAassistant commented Dec 24, 2023

CLA assistant check
All committers have signed the CLA.

@aeneasr
Copy link
Member

aeneasr commented Jan 4, 2024

Closing as per #303 (comment)

@aeneasr aeneasr closed this Jan 4, 2024
@aeneasr
Copy link
Member

aeneasr commented Jan 4, 2024

Closing as per #303 (comment)

@aeneasr aeneasr reopened this Jan 4, 2024
@aeneasr aeneasr closed this Jan 4, 2024
@amirzahavi
Copy link
Author

Hey @aeneasr,
I understand now that the code is auto-generated, unfortunately, the linked comment states that it will be done in a couple of days (Nov 2023), but the Axios dependency is still a very old version.

Thanks 🙏🏽

@Oscmage
Copy link

Oscmage commented Jan 12, 2024

Hey @aeneasr

To @amirzahavi point, from what I can see the client is still a two year old version of Axios(or am I missing something?):

https://github.com/ory/sdk/blob/master/clients/client/typescript/package-lock.json#L30-L31

It is difficult for us to motivate staying customers of Ory Network (which was primarily a move done for security purposes) if dependencies to client libraries are not maintained, especially when the dependencies have open security vulnerabilities.

Do you run vulnerability scanning on the SDKs that you mention on your webpage?

@Oscmage
Copy link

Oscmage commented Jan 30, 2024

In 1.5.2 version of the client it uses a new version of axios 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants