WizardV2: enable V2 by default on preview and ephemeral #2081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jrusz ^^ :) |
|
/retest |
1 similar comment
|
/retest |
ezr-ondrej
force-pushed
the
default_v2
branch
3 times, most recently
from
623b27e
to
e798349
Compare
|
@jrusz I think that now it's failing because it is trying the old workflow :) |
Yes I'm looking into it, I can see the new wizard in ephemeral by default but I'm not sure why it's failing yet, having some trouble running tests locally against ephemeral. |
|
/retest |
|
Package search doesn't work in ephemeral, not sure why. I'll skip adding packages in ephemeral for now to unblock this. |
|
/retest |
1 similar comment
|
/retest |
regexowl
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the need for a feature flag in Beta environments.
I see this as a natural first step - enable it in all Beta (including Ephemeral) environments without feature flag.
If we prefer to do default in Ephemeral only, let me know :)