Search against content sources for distro packages (HMS-4094) #2083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
croissanne
force-pushed
the
content-sources-only
branch
2 times, most recently
from
ec0de23
to
19722b4
Compare
croissanne
force-pushed
the
content-sources-only
branch
from
19722b4
to
4244938
Compare
mgold1234
reviewed
May 16, 2024
src/test/Components/CreateImageWizardV2/steps/Packages/Packages.test.tsx
Outdated
Show resolved
Hide resolved
croissanne
force-pushed
the
content-sources-only
branch
2 times, most recently
from
5d80f08
to
66e2e83
Compare
croissanne
changed the title
|
/retest |
croissanne
force-pushed
the
content-sources-only
branch
from
66e2e83
to
f42800c
Compare
This will make it easier to search for distro groups, as those are only available for searching in the content-sources api.
regexowl
force-pushed
the
content-sources-only
branch
from
f42800c
to
e74584b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches over to content sources entirely. For package groups we'll need to use content sources as well, so I think it makes sense. This keeps the custom and distro packages query separated, because we do some heuristics there.
I also noticed that distro packages are search when there's 2 characters, and custom/recommends when there's 3 or more. Could change this to be consistent.
I removed the v1 wizard test without concent sources entirely.