-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makefile: implement "fully source containers" HMS-3883 #19
Draft
schuellerf
wants to merge
14
commits into
osbuild:main
Choose a base branch
from
schuellerf:HMS-3883-fully-source-containers
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Makefile: implement "fully source containers" HMS-3883 #19
schuellerf
wants to merge
14
commits into
osbuild:main
from
schuellerf:HMS-3883-fully-source-containers
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moving depsolve to `osbuild` moved things around and requires different RPMs, we only hit this issue because we install directly from RPMs. This makes all containers able to build with `sudo make quick`.
The depsolve path was set to the old location making the entrypoint fail.
osbuild-composer expects a cloudapi socket to be created in more recent versions; let's create it and pass it along through our fake systemd entrypoint.
schuellerf
force-pushed
the
HMS-3883-fully-source-containers
branch
4 times, most recently
from
April 12, 2024 07:25
a4c3c34
to
d2bea49
Compare
schuellerf
force-pushed
the
HMS-3883-fully-source-containers
branch
4 times, most recently
from
April 16, 2024 11:38
6aad219
to
a06bc1c
Compare
activate the composer config by copying to the correct name
schuellerf
force-pushed
the
HMS-3883-fully-source-containers
branch
2 times, most recently
from
April 23, 2024 17:48
fad9a66
to
2ca8f60
Compare
schuellerf
force-pushed
the
HMS-3883-fully-source-containers
branch
2 times, most recently
from
May 3, 2024 12:23
bf51153
to
933ce25
Compare
also changes compose file to be more robust on startup use docker as default for now podman does not seem to run stable. will need to investigate more
schuellerf
force-pushed
the
HMS-3883-fully-source-containers
branch
from
May 8, 2024 17:20
933ce25
to
b93cac9
Compare
schuellerf
force-pushed
the
HMS-3883-fully-source-containers
branch
from
May 23, 2024 07:01
36a622c
to
b03a72d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting the stack up and running locally but all from source