linux: add new mount/umount2 libc6 wrappers #1652
Conversation
| for path, content in fake_content.items(): | ||
| dirp, name = os.path.split(os.path.join(basedir, path.lstrip("/"))) | ||
| os.makedirs(dirp, exist_ok=True) | ||
| if content is not None: |
There was a problem hiding this comment.
Can't be None according to type annotation, you probably want if content: to check if the dict has any values in it.
|
This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days. |
To avoid having to use an external "mount" binary (and having to deal with the selinux labeling) this commit adds new "mount" and "umount2" syscalls to the osbuild.util.linux package and the coresponding tests.
|
This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days. |
|
I close this for now as we have not clear use case (anymore, it was bib and selinux). I still think it might be nice to have but it's not urgent and we can always resurrect it. Note that the bigger problem with moving to mount/umount syscalls is the libmount recursive unmount support which is very nice to have and which we would have to write on our own if we want to go full no-{,u}mount-binary (not a big deal but extra work and testing) |
To avoid having to use an external "mount" binary (and having to deal with the selinux labeling) this commit adds new "mount" and "umount2" syscalls to the osbuild.util.linux package and the coresponding tests.