Makefile: implement "fully source containers" HMS-3883 #1704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elkoniu
reviewed
Apr 5, 2024
|
|
||
| # Function to search for Python files in a directory | ||
| define find_python_files | ||
| $(shell find $(1) -type f -exec file {} \; | grep "Python script" | grep -Eo "^[^:]+") |
There was a problem hiding this comment.
If this will catch also stage files? They lack .py extension. There is also stage org.osbuild.tar which is python file but frequently by script is processed as a tar archive:)
There was a problem hiding this comment.
That's the only reason for this not-so-nicce find-grep pipe - to get those files in consideration :-)
There was a problem hiding this comment.
Just running in the osbuild directory should show them all...
find . -type f -exec file {} \; | grep "Python script" | grep -Eo "^[^:]+"
(actually I now see that I have ".py" files twice - but that won't hurt make I guess)
schuellerf
force-pushed
the
HMS-3883-fully-source-containers
branch
from
8d94980
to
5c55362
Compare
schuellerf
force-pushed
the
HMS-3883-fully-source-containers
branch
from
5c55362
to
cacfca6
Compare
schuellerf
force-pushed
the
HMS-3883-fully-source-containers
branch
from
cacfca6
to
9c70e64
Compare
|
This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting the stack up and running locally but all from source