stages: Add new stage parameter to org.osbuild.ovf #1751
Conversation
| "ostype": { | ||
| "description": "The kind of installed guest operating system", | ||
| "type": "string", | ||
| "default": "other26xLinux64Guest" |
There was a problem hiding this comment.
How long is the list of valid values here? Does it make sense to make it an enum to verify that only valid values are used?
There was a problem hiding this comment.
According to the list I found it may be quite long: https://docs.vmware.com/en/VMware-HCX/4.9/hcx-user-guide/GUID-D4FFCBD6-9FEC-44E5-9E26-1BD0A2A81389.html
Also we would need to track this list in case something will change.
This whole PR is related to QA request where they would like to be able to "eventually" overwrite default value so I guess in the normal circumstances this wount be used that frequent:)
osType used in this stage has hardcoded osType value in the template. This commit allows to overwrite this value if needed.
elkoniu
force-pushed
the
org.osbuild.ovf-add-parameter
branch
from
1e11892
to
05fbf57
Compare
| @@ -22,7 +22,7 @@ OVF_TEMPLATE = """<?xml version="1.0"?> | |||
| <VirtualSystem ovf:id="image"> | |||
| <Info>A virtual machine</Info> | |||
| <Name>VM</Name> | |||
| <OperatingSystemSection ovf:id="100" vmw:osType="other26xLinux64Guest"> | |||
| <OperatingSystemSection ovf:id="100" vmw:osType={"ostype"}> | |||
There was a problem hiding this comment.
| <OperatingSystemSection ovf:id="100" vmw:osType={"ostype"}> | |
| <OperatingSystemSection ovf:id="100" vmw:osType={ostype}> |
need to drop the quotes.
There was a problem hiding this comment.
Nice catch, it seems the string is also not an f-string so that would need changing too.
| @@ -22,7 +22,7 @@ OVF_TEMPLATE = """<?xml version="1.0"?> | |||
| <VirtualSystem ovf:id="image"> | |||
| <Info>A virtual machine</Info> | |||
| <Name>VM</Name> | |||
| <OperatingSystemSection ovf:id="100" vmw:osType="other26xLinux64Guest"> | |||
| <OperatingSystemSection ovf:id="100" vmw:osType={"ostype"}> | |||
There was a problem hiding this comment.
Nice catch, it seems the string is also not an f-string so that would need changing too.
|
This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days. |
|
This PR was closed because it has been stalled for 30+7 days with no activity. |
osType used in this stage has hardcoded osType value in the template. This commit allows to overwrite this value if needed.