Fixed #375

CHANGELOG.md

@@ -5,6 +5,10 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/)
 and this project adheres to [Semantic Versioning](http://semver.org/).
 
+## [4.2.5] - 2020-08-01
+### Fixed
+- Github TypeError exception with some urls [#375]
+
 ## [4.2.4] - 2020-07-06
 ### Fixed
 - Ignore invalid urls instead throw an exception
@@ -74,7 +78,9 @@ Full library refactoring.
 [#356]: https://github.com/oscarotero/Embed/issues/356
 [#357]: https://github.com/oscarotero/Embed/issues/357
 [#366]: https://github.com/oscarotero/Embed/issues/366
+[#375]: https://github.com/oscarotero/Embed/issues/375
 
+[4.2.5]: https://github.com/oscarotero/Embed/compare/v4.2.4...v4.2.5
 [4.2.4]: https://github.com/oscarotero/Embed/compare/v4.2.3...v4.2.4
 [4.2.3]: https://github.com/oscarotero/Embed/compare/v4.2.2...v4.2.3
 [4.2.2]: https://github.com/oscarotero/Embed/compare/v4.2.1...v4.2.2

src/Adapters/Github/Detectors/Code.php

@@ -41,5 +41,7 @@ private function fallback(): ?EmbedCode
                 //https://help.github.com/articles/3d-file-viewer/#embedding-your-model-elsewhere
                 return new EmbedCode(html('script', ['src' => "https://embed.githubusercontent.com/view/3d/{$username}/{$repo}/{$ref}/{$file}"]));
         }
+
+        return null;
     }
 }

tests/PagesTest.php

@@ -136,6 +136,7 @@ public function testGithub()
         $this->assertEmbed('https://gist.github.com/oscarotero/7749998');
         $this->assertEmbed('https://github.com/benbalter/dc-wifi-social/blob/master/bars.geojson');
         $this->assertEmbed('https://github.com/skalnik/secret-bear-clip/blob/master/stl/clip.stl');
+        $this->assertEmbed('https://github.com/oscarotero/Embed/blob/master/composer.json');
     }
 
     public function testGoogle()