Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make macos logger as copy of linux logger #125

Closed
wants to merge 1 commit into from

Conversation

alekseytomin
Copy link

If you use kotlin 1.4 - you can merge macos and linux (and minGW - I'm doing it later)

@oshai
Copy link
Owner

oshai commented Aug 18, 2020

Thanks for the PR!
I am not sure I understood your comment. If we upgrade to Kotlin 1.4 this code is mostly redundant?
If so, I think it's better to upgrade to 1.4 first and then add only the required parts.
In addition, I think we didn't manage to publish linux artefacts yet, in case you have insights about that.

@alekseytomin
Copy link
Author

@oshai
Copy link
Owner

oshai commented Aug 19, 2020

ok, then see #127. we will merge it before this PR.

@alekseytomin
Copy link
Author

Replaced by #131

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants