Move throttling of request processing from middleware to rate limiter setup #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shalarewicz
force-pushed
the
sh/rate-limiter-throttle
branch
from
43116b0
to
200948d
Compare
evanmcneely
reviewed
Aug 18, 2022
evanmcneely
requested changes
Aug 18, 2022
added comments on throttled processRequest
…phQL-Gate into sh/rate-limiter-throttle
|
Addressed requested changes. Tests continue to pass. |
evanmcneely
approved these changes
Aug 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Moves throttling request processing to rate limiter setup to ensure all rate limiters are throttled and not just that of the express middleware.
Type of Change
Please delete options that are not relevant.
Issues
Evidence