Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catch.hpp: restore PPC support #360

Closed
wants to merge 2 commits into from
Closed

Conversation

barracuda156
Copy link

PPC define taken from earlier version of libosmium:

#if defined(__ppc64__) || defined(__ppc__)

Second commit is non-functional: removal of few unneeded double spaces.

@joto
Copy link
Member

joto commented Jan 11, 2023

catch.hpp is included as is from its upstream source. It is not maintained here. Please solve this issue with upstream (https://github.com/catchorg/Catch2).

@barracuda156
Copy link
Author

catch.hpp is included as is from its upstream source. It is not maintained here. Please solve this issue with upstream (https://github.com/catchorg/Catch2).

I have opened a PR there: catchorg/Catch2#2619
No idea how long it gonna take to merge it and then have it updated here after that.

@joto
Copy link
Member

joto commented Jan 15, 2023

It has been merged upstream, but note that Osmium still uses Catch v2, not the current v3, so unless somebody ports you change back to v2, this might not end up there. I am closing this issue here now because there is nothing to be done here. I'll update the enclosed Catch version before releasing a new Osmium version to whatever is current at that time (but still Catch v2), I can't do more at the moment.

@joto joto closed this Jan 15, 2023
@barracuda156
Copy link
Author

Thank you. Do you suggest backporting with upstream to get it into catch2?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants