Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Tesco Lotus Express to Lotus's go fresh #9486

Merged
merged 5 commits into from
May 24, 2024

Conversation

ckpiper
Copy link
Collaborator

@ckpiper ckpiper commented May 15, 2024

From this conversation it seems like Lotus's go fresh can be big enough to be considered a supermarket as well as a convenience store. Thus I added it to both.

Then from Wikipedia we can see that once CP Group took control they started by removing Tesco from the names. I put it under match names as some stores may still have the sign up. Not sure how long that takes to completely change all shops.

@bhousel bhousel merged commit c4390ab into osmlab:main May 24, 2024
2 checks passed
@bhousel
Copy link
Member

bhousel commented May 24, 2024

Thanks 👍
I noticed we already had another "Tesco Lotus" brand in the index, also in my,th, that got rebranded.

That other one is preserving the former name in alt_name tag, so I did the same for "Lotus's go fresh". Our convention is to use alt_name for a former name that's in the process of being phased out, but still might appear on signs or people might search for it.

I'm keeping them both, so I put them like this in c4390ab, since I don't know whether there's any difference, and they do have 2 different QIDs now:

    {
      "displayName": "Lotus's",
      "id": "lotuss-a5f134",
      "locationSet": {"include": ["my", "th"]},
      "tags": {
        "alt_name": "Tesco Lotus",
        "brand": "Lotus's",
        "brand:en": "Lotus's",
        "brand:th": "โลตัส",
        "brand:wikidata": "Q2378901",
        "name": "Lotus's",
        "name:en": "Lotus's",
        "name:th": "โลตัส",
        "shop": "supermarket"
      }
    },
    {
      "displayName": "Lotus's go fresh",
      "id": "lotussgofresh-a5f134",
      "locationSet": {"include": ["my", "th"]},
      "tags": {
        "alt_name": "Tesco Lotus Express",
        "brand": "Lotus's go fresh",
        "brand:wikidata": "Q125937967",
        "name": "Lotus's go fresh",
        "shop": "supermarket"
      }
    },

@ckpiper ckpiper deleted the update_tesco_lotus_express branch May 28, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants