Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependencies / Release with go 1.17 #2533

Closed
wants to merge 3 commits into from
Closed

Conversation

mrueg
Copy link
Contributor

@mrueg mrueg commented Mar 14, 2022

This updates dependencies and builds the binaries with go 1.17.
Happy to update further, if we are okay with breaking compatibility with go <=1.16.

github.com/osrg/gobgp/v3/cmd/gobgp tested by
        github.com/osrg/gobgp/v3/cmd/gobgp.test imports
        github.com/stretchr/testify/assert imports
        gopkg.in/yaml.v3 tested by
        gopkg.in/yaml.v3.test imports
        gopkg.in/check.v1 loaded from gopkg.in/check.v1@v1.0.0-20180628173108-788fd7840127,
        but go 1.16 would select v1.0.0-20190902080502-41f04d3bba15

To upgrade to the versions selected by go 1.16:
        go mod tidy -go=1.16 && go mod tidy -go=1.17
If reproducibility with go 1.16 is not needed:
        go mod tidy -compat=1.17
For other options, see:
        https://golang.org/doc/modules/pruning

Signed-off-by: Manuel Rüger <manuel@rueg.eu>
Signed-off-by: Manuel Rüger <manuel@rueg.eu>
Signed-off-by: Manuel Rüger <manuel@rueg.eu>
@fujita
Copy link
Member

fujita commented Mar 18, 2022

Any specific reasons for updating dependencies?

@jauderho
Copy link

FWIW, now that Go 1.18 has been released, Go 1.16 is no longer considered supported. @mrueg This should be rebased to Go 1.18 if you are going through the effort of updating things.

https://endoflife.date/go

@fujita
Copy link
Member

fujita commented Mar 20, 2022

You can build the current code with Go 1.18. What's the point of breaking compatibility with old go versions?

@mrueg
Copy link
Contributor Author

mrueg commented Mar 23, 2022

Any specific reasons for updating dependencies?

@fujita
Copy link
Member

fujita commented Mar 23, 2022

Sounds reasonable. Pushed, thanks!

@fujita fujita closed this Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants