-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Record the proper clone URL in the provenance #5852
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportBase: 57.74% // Head: 57.56% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #5852 +/- ##
============================================
- Coverage 57.74% 57.56% -0.18%
Complexity 2219 2219
============================================
Files 326 327 +1
Lines 19023 19092 +69
Branches 3735 3747 +12
============================================
+ Hits 10985 10991 +6
- Misses 6899 6963 +64
+ Partials 1139 1138 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Note to myself: This raises the interesting
test failure as with Subversion the tag is part of the URL. |
This increases reability and implicitly gives the formerly anonymous class a name so it can later be referred to. Slightly reorder functions while at it, so overridden function fo first and private functions go last. Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
Earlier fallbacks might have tampered with the original URL (e.g. by stripping credentials), so the `RepositoryProvenance` should record the actual URL being used for creating the `WorkingTree`. Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
1d169b7
to
8e2ea6a
Compare
Please have a look at the individual commit messages for the details.