-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Bump github.com/golangci/golangci-lint from 1.57.2 to 1.58.1 in /tools #4108
🌱 Bump github.com/golangci/golangci-lint from 1.57.2 to 1.58.1 in /tools #4108
Conversation
Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint) from 1.57.2 to 1.58.1. - [Release notes](https://github.com/golangci/golangci-lint/releases) - [Changelog](https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md) - [Commits](golangci/golangci-lint@v1.57.2...v1.58.1) --- updated-dependencies: - dependency-name: github.com/golangci/golangci-lint dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4108 +/- ##
==========================================
- Coverage 66.06% 61.93% -4.14%
==========================================
Files 226 209 -17
Lines 16291 15329 -962
==========================================
- Hits 10763 9494 -1269
- Misses 4854 5136 +282
- Partials 674 699 +25 |
Signed-off-by: Spencer Schrock <sschrock@google.com>
now that max is a go builtin, the linter started flagging this Signed-off-by: Spencer Schrock <sschrock@google.com>
…gci/golangci-lint-1.58.1 Signed-off-by: Spencer Schrock <sschrock@google.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Highlighted changes that required changes:
goerr113 is replaced by err113
⚠️
(really this is just a rename)
gocritic: from 0.11.2 to 0.11.3
where 0.11.3 started checking shadowing for max
and min
Now make check-linter
is running clean.
@dependabot squash and merge |
Bumps github.com/golangci/golangci-lint from 1.57.2 to 1.58.1.
Release notes
Sourced from github.com/golangci/golangci-lint's releases.
... (truncated)
Changelog
Sourced from github.com/golangci/golangci-lint's changelog.
... (truncated)
Commits
dc28153
build(deps): bump github.com/4meepo/tagalign from 1.3.3 to 1.3.4 (#4705)9116634
build(deps): bump github.com/ghostiam/protogetter from 0.3.5 to 0.3.6 (#4707)d64e1de
build(deps): bump golang.org/x/tools from 0.20.0 to 0.21.0 (#4706)6767d7c
fix: remove GitHub Action problem matchers (#4700)ee97dbf
build(deps): bump golangci/golangci-lint-action from 5.1.0 to 5.3.0 (#4701)9209e3e
build(deps): bump golang.org/x/oauth2 from 0.19.0 to 0.20.0 in /scripts/gen_g...4532eb9
fix: gochecknoinits shadow name (#4698)4bf574a
chore: keep v1.57 JSON schema30c05e9
docs: update documentation (#4694)620a72c
docs: update documentation assets (#4692)You can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot will merge this PR once CI passes on it, as requested by @spencerschrock.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)