マイページ繋ぎ込み #428
Merged
マイページ繋ぎ込み #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/koukinagata/sushi-chat/BsHpM5dD4Jv6pu5mgDgUZuCTTgMD |
Eri-0910
requested review from
knknk98,
yuta-ike,
TOMOFUMI-KONDO and
KoukiNAGATA
|
@Eri-0910 |
|
あー、手でDBに値入れないと見れない…… |
yuta-ike
reviewed
Sep 23, 2021
|
@Eri-0910 |
|
おお、ありがとう！ |
yuta-ike
reviewed
Sep 23, 2021
app/front/pages/home.vue
Outdated
| @@ -34,11 +34,11 @@ | |||
| :to="{ path: '/', query: { roomId: room.id, user: 'admin' } }" | |||
| class="home-top__event--item" | |||
| > | |||
| <div class="home-top__event__list"> | |||
| <button class="home-top__event__list"> | |||
There was a problem hiding this comment.
あっ、ここはbuttonじゃない方が良い気がする。NuxtLinkで既にaタグで囲まれている（と思われる）ので！
yuta-ike
approved these changes
Sep 23, 2021
Eri-0910
force-pushed
the
feature/home-rest
branch
from
487fc3e
to
55478f0
Compare
|
頭回らんくてmergeじゃなくてrebaseしちゃいましたのpush -fです |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #xxx
やったこと
開催中のイベント・未開始のイベント・終了したイベントの表示
終了したイベントをアーカイブする
日付は固定幅にした
RESTのput修正した
参考リンク・補足など