Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hang issue #5

Merged
merged 1 commit into from Sep 3, 2022
Merged

Fix hang issue #5

merged 1 commit into from Sep 3, 2022

Conversation

ota-meshi
Copy link
Owner

No description provided.

@ota-meshi ota-meshi merged commit e7d223e into main Sep 3, 2022
@ota-meshi ota-meshi deleted the fix branch September 3, 2022 12:49
@JounQin
Copy link

JounQin commented Sep 28, 2022

@ota-meshi Hi, so un-ts/synckit#101 does not help in this case? Is that possible to be fixed on synckit's side?

@ota-meshi
Copy link
Owner Author

This issue is not a synckit issue.
I think it's a problem with astrojs/compiler or whatever tool generates that wasm.
astrojs/compiler seems to call process.exit() on error. So the worker suddenly disappears without any notification.
This PR is a change that works around that issue.

@JounQin
Copy link

JounQin commented Sep 29, 2022

Thanks for explanation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ota-meshi @JounQin