fix: useSchemastoreCatalog is enabled by default according to docs. (…

…#305) * fix: `useSchemastoreCatalog` is enabled by default according to docs. * Create sixty-mice-arrive.md * add test
ota-meshi · Mar 23, 2024 · ada5a08 · ada5a08
1 parent f65a640
commit ada5a08
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 1 deletion.
diff --git a/.changeset/sixty-mice-arrive.md b/.changeset/sixty-mice-arrive.md
@@ -0,0 +1,5 @@
+---
+"eslint-plugin-json-schema-validator": major
+---
+
+fix: `useSchemastoreCatalog` is enabled by default according to docs.
diff --git a/src/rules/no-invalid.ts b/src/rules/no-invalid.ts
@@ -403,7 +403,8 @@ export default createRule("no-invalid", {
       relativeFilename: string,
     ): Validator[] | null {
       const option = context.options[0] || {};
-      if (!option.useSchemastoreCatalog) {
+      const useSchemastoreCatalog = option.useSchemastoreCatalog !== false;
+      if (!useSchemastoreCatalog) {
         return null;
       }
 

diff --git a/tests/src/rules/no-invalid.ts b/tests/src/rules/no-invalid.ts
@@ -42,6 +42,15 @@ tester.run(
         },
       ],
       invalid: [
+        {
+          filename: ".eslintrc.json",
+          code: '{ "extends": [ 42 ] }',
+          errors: [
+            '"extends" must be string.',
+            '"extends" must match exactly one schema in oneOf.',
+            '"extends[0]" must be string.',
+          ],
+        },
         {
           filename: ".eslintrc.json",
           code: '{ "extends": [ 42 ] }',