CHANGELOG.md

@@ -1,5 +1,11 @@
 # eslint-plugin-json-schema-validator
 
+## 5.0.0
+
+### Major Changes
+
+- [#305](https://github.com/ota-meshi/eslint-plugin-json-schema-validator/pull/305) [`ada5a08`](https://github.com/ota-meshi/eslint-plugin-json-schema-validator/commit/ada5a0818d0f067a99dcfe3e134acac218479536) Thanks [@ota-meshi](https://github.com/ota-meshi)! - fix: `useSchemastoreCatalog` is enabled by default according to docs.
+
 ## 4.9.0
 
 ### Minor Changes

docs/.vuepress/components/playground-block.vue

@@ -218,13 +218,13 @@ export default {
 };
 
 function equalsRules(a, b) {
-  const akeys = Object.keys(a).filter((k) => a[k] !== "off");
-  const bkeys = Object.keys(b).filter((k) => b[k] !== "off");
-  if (akeys.length !== bkeys.length) {
+  const aKeys = Object.keys(a).filter((k) => a[k] !== "off");
+  const bKeys = Object.keys(b).filter((k) => b[k] !== "off");
+  if (aKeys.length !== bKeys.length) {
     return false;
   }
 
-  for (const k of akeys) {
+  for (const k of aKeys) {
     if (a[k] !== b[k]) {
       return false;
     }

docs/.vuepress/components/stylelint.config.js

@@ -1,7 +1,11 @@
 module.exports = {
-  extends: ["stylelint-config-standard", "stylelint-config-recommended-vue"],
+  extends: [
+    "stylelint-config-standard",
+    "stylelint-config-recommended-vue",
+    "@stylistic/stylelint-config",
+  ],
   rules: {
     "no-descending-specificity": null,
-    indentation: null,
+    "@stylistic/indentation": null,
   },
 };

docs/.vuepress/config.js

@@ -7,6 +7,10 @@ const schema = require("../../lib/utils/schema");
 schema.loadJson("https://www.schemastore.org/api/json/catalog.json", {});
 schema.loadSchema("https://json.schemastore.org/eslintrc.json", {});
 schema.loadSchema("https://json.schemastore.org/prettierrc.json", {});
+schema.loadSchema(
+  "https://json.schemastore.org/partial-eslint-plugins.json",
+  {},
+);
 
 function ruleToLink({
   meta: {

docs/.vuepress/styles/stylelint.config.js

@@ -1,5 +1,9 @@
 module.exports = {
-  extends: ["stylelint-config-standard", "stylelint-stylus/standard"],
+  extends: [
+    "stylelint-config-standard",
+    "stylelint-stylus/standard",
+    "@stylistic/stylelint-config",
+  ],
   rules: {
     "no-descending-specificity": null,
     "selector-class-pattern": null,

package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-json-schema-validator",
-  "version": "4.9.0",
+  "version": "5.0.0",
   "description": "ESLint plugin that validates data using JSON Schema Validator.",
   "repository": "git+https://github.com/ota-meshi/eslint-plugin-json-schema-validator.git",
   "homepage": "https://ota-meshi.github.io/eslint-plugin-json-schema-validator/",
@@ -67,10 +67,11 @@
     "@changesets/changelog-github": "^0.5.0",
     "@changesets/cli": "^2.24.2",
     "@ota-meshi/eslint-plugin": "^0.15.0",
+    "@stylistic/stylelint-config": "^1.0.1",
     "@types/debug": "^4.1.5",
     "@types/eslint": "^8.56.2",
     "@types/eslint-scope": "^3.7.0",
-    "@types/eslint-visitor-keys": "^1.0.0",
+    "@types/eslint-visitor-keys": "^3.0.0",
     "@types/estree": "^1.0.0",
     "@types/mocha": "^10.0.0",
     "@types/node": "^20.0.0",

src/rules/no-invalid.ts

@@ -403,7 +403,8 @@ export default createRule("no-invalid", {
       relativeFilename: string,
     ): Validator[] | null {
       const option = context.options[0] || {};
-      if (!option.useSchemastoreCatalog) {
+      const useSchemastoreCatalog = option.useSchemastoreCatalog !== false;
+      if (!useSchemastoreCatalog) {
         return null;
       }
 

src/utils/validator-factory.ts

@@ -5,7 +5,6 @@ import type {
   ValidateFunction,
   RegExpEngine,
 } from "./ajv";
-import { URL } from "url";
 import type { RuleContext } from "../types";
 import Ajv from "./ajv";
 import { draft7 as migrateToDraft7 } from "json-schema-migrate";

tests/src/rules/no-invalid.ts

@@ -42,6 +42,15 @@ tester.run(
         },
       ],
       invalid: [
+        {
+          filename: ".eslintrc.json",
+          code: '{ "extends": [ 42 ] }',
+          errors: [
+            '"extends" must be string.',
+            '"extends" must match exactly one schema in oneOf.',
+            '"extends[0]" must be string.',
+          ],
+        },
         {
           filename: ".eslintrc.json",
           code: '{ "extends": [ 42 ] }',