Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add no-non-standard-flag rule #167

Merged
merged 4 commits into from
Apr 20, 2021
Merged

Add no-non-standard-flag rule #167

merged 4 commits into from
Apr 20, 2021

Conversation

RunDevelopment
Copy link
Collaborator

This implements this comment.

Since we now have 3 rules that report/replace flags, I moved the common flags logic into RegExpContext.


There is still one problem with this PR: the website:

image

We probably have to use @typescript-eslint/parser on the website as well.
@ota-meshi Should we do this? If yes, how?

@RunDevelopment RunDevelopment changed the title Add no-non-standard-flags rule Add no-non-standard-flag rule Apr 20, 2021
@ota-meshi
Copy link
Owner

We probably have to use @typescript-eslint/parser on the website as well.
@ota-meshi Should we do this? If yes, how?

Hmm.. @typescript-eslint/parser requires a very large resource because it requires typescript. So I don't want to include @typescript-eslint/parser 😅.
Can you avoid it with example without demo and example with demo using new RegExp()?

@RunDevelopment
Copy link
Collaborator Author

demo using new RegExp()?

Good idea!

Copy link
Owner

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@ota-meshi ota-meshi merged commit 30c3a1b into master Apr 20, 2021
@ota-meshi ota-meshi deleted the no-non-standard-flags branch April 20, 2021 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants