Improve prefer-lookaround rule to report when there are leading/trailing assertions
#480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/rules/prefer-lookaround.ts
Outdated
| @@ -172,6 +180,190 @@ function getSideEffectsWhenReplacingCapturingGroup( | |||
| } | |||
| } | |||
|
|
|||
| /** Checks if the given element is a zero length element that can be placed as a leading/trailing element. */ | |||
| function isLeadingTrailingElement(element: Element): boolean { | |||
| if (element.type === "CapturingGroup") return false | |||
There was a problem hiding this comment.
Why is it not allowed to be a capturing groups? A zero-length capturing group is useless, but would it be wrong if we transformed those capturing groups? E.g. /foo(bar)(\b|$)/ -> /foo(?=bar(\b|$))/ should be fine as long as this capturing group isn't used in the replacement string, right?
There was a problem hiding this comment.
You're right! I will change this PR.
RunDevelopment
approved these changes
Nov 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #478