Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove intl-segmenter-polyfill #735

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ota-meshi
Copy link
Owner

This PR removes intl-segmenter-polyfill.
intl-segmenter-polyfill was used on our site. This is because Intl.Segmenter did not work in FireFox.
However, FireFox now supports Intl.Segmenter, so intl-segmenter-polyfill is no longer needed.

https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/125

Copy link

changeset-bot bot commented Apr 19, 2024

⚠️ No Changeset found

Latest commit: 943a333

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@RunDevelopment
Copy link
Collaborator

This update has been released 3 days ago. Should we wait a little to give people time to update their browser?

@ota-meshi
Copy link
Owner Author

I don't need it right away, so it can wait 👍 Should we wait about a month?

@RunDevelopment
Copy link
Collaborator

A month sounds good. The release cycle of Firefox seems to be 4 weeks, so giving people one version as a buffer should be good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants