Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove import as a JS reserved word #179

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jackfranklin
Copy link

Now that JS supports import('/foo.js') it shouldn't be marked as a
reserved word when used in blocks.

This is my first time changing a Vim syntax so apologies if this isn't the right fix - do let me know if you'd like me to make changes. This fixed the problem I was having locally where import was highlighted in red as if it were an error.

Now that JS supports `import('/foo.js')` it shouldn't be marked as a
reserved word when used in blocks.
@othree
Copy link
Owner

othree commented May 17, 2020

Hi, thanks for your PR. Your change can fix this issue however I don't expect it solve in this way. I will keep this reserved word and add extra def to over write it in expected context. Actually I have supported import() in another repo: https://github.com/othree/es.next.syntax.vim/blob/master/after/syntax/javascript.vim#L65-L69

This should move to here when it got official support but I forgot to do it. You can help me update the PR to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants